fix(user settings): Update forked cosmo theme to resolve down chevron in caret style (#30514) #30577
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The issue is caused by a custom style in the forked version of cosmo bootswatch.less that was added in the original multi-panel sqllab PR. The style overrides the caret style that is part of the bootstrap dropdown.less and references the FontAwesome font which is no longer included. The fix updates the bootswatch style to use Glyphicons down-chevron icon that is similar to the icons used in the React implementations. An alternative would be to remove the style from bootswatch completely, which can be seen in the ALTERNATE screenshot below.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE:
AFTER:
ALTERNATE: would be implemented by completely removing the caret style in the forked bootswatch.less and allowing boostrap dropdowns.less style to be applied:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION
Fixes #30514